Skip to contentSkip to conversation

Change in openvpn[master]: manage: Do not trigger actions on management disconnect if not authen...

Openvpn-devel In review flichtenheld (Code Review) 3 participants 6 messages Jan 21 – Jan 27 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): gerrit.1769005798000.I575d65912ce9065a0b0868e73998b4a9aece62af@...2715...

#1 lore raw

Attention is currently required from: plaisthos.

Hello plaisthos,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/1484?usp=email

to review the following change.

Change subject: manage: Do not trigger actions on management disconnect if not authenticated
......................................................................

manage: Do not trigger actions on management disconnect if not authenticated

If the management interface requires authentication via password and the remote did not specify it, do not do trigger actions requested by --management-forget-disconnect and --management-signal on disconnect.

Github: openvpn-private-issues#5

Change-Id I575d65912ce9065a0b0868e73998b4a9aece62af

---
M src/openvpn/manage.c

1 file changed, 3 insertions(+), 2 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/84/1484/1

src/openvpn/manage.c +3 -2
index 8fa8784..37ae6b3 100644
@@ -2073,13 +2073,14 @@
     }
     if (!exiting)
     {
-        if (man->settings.flags & MF_FORGET_DISCONNECT)
+        if (man->settings.flags & MF_FORGET_DISCONNECT && !man_password_needed(man))
         {
+            msg(D_MANAGEMENT, "MANAGEMENT: Reset authentication on disconnect");
             ssl_purge_auth(false);
             (void)ssl_clean_auth_token();
         }
 
-        if (man->settings.flags & MF_SIGNAL)
+        if (man->settings.flags & MF_SIGNAL && !man_password_needed(man))
         {
             int mysig = man_mod_signal(man, SIGUSR1);
             if (mysig >= 0)

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1484?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I575d65912ce9065a0b0868e73998b4a9aece62af
Gerrit-Change-Number: 1484
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>

#2 lore raw
In reply to a message not in the archive

Attention is currently required from: flichtenheld.

plaisthos has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1484?usp=email )

Change subject: manage: Do not trigger actions on management disconnect if not authenticated
......................................................................

Patch Set 1: Code-Review+2

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1484?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I575d65912ce9065a0b0868e73998b4a9aece62af
Gerrit-Change-Number: 1484
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Thu, 22 Jan 2026 12:44:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

#3 lore raw

PATCH 1/1 manage: Do not trigger actions on management disconnect if not authenticated

In reply to a message not in the archive

If the management interface requires authentication via password and the remote did not specify it, do not do trigger actions requested by --management-forget-disconnect and --management-signal on disconnect.

Github: openvpn-private-issues#5

Change-Id I575d65912ce9065a0b0868e73998b4a9aece62af

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1484
---

This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1484
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Arne Schwabe <[email protected]...>

src/openvpn/manage.c +3 -2
index 8fa8784..37ae6b3 100644
@@ -2073,13 +2073,14 @@
     }
     if (!exiting)
     {
-        if (man->settings.flags & MF_FORGET_DISCONNECT)
+        if (man->settings.flags & MF_FORGET_DISCONNECT && !man_password_needed(man))
         {
+            msg(D_MANAGEMENT, "MANAGEMENT: Reset authentication on disconnect");
             ssl_purge_auth(false);
             (void)ssl_clean_auth_token();
         }
 
-        if (man->settings.flags & MF_SIGNAL)
+        if (man->settings.flags & MF_SIGNAL && !man_password_needed(man))
         {
             int mysig = man_mod_signal(man, SIGUSR1);
             if (mysig >= 0)
#4 lore raw

[Openvpn-devel] [PATCH applied] Re: manage: Do not trigger actions on management disconnect if not authenticated

Confirmed - run a server instance with "--management-disconnect" *and* a management password set up, and without this patch, "connect and disconnect" (without entering a password) will disconnect all clients.

We do not consider this to be a security relevant bug ("CVE assigned") as it needs quite a lot of prerequisites - "management interface active, while no management client using this" plus setting "--management-disconnect" on a server instance, which is somewhat questionable to begin with...

Still, it needs fixing :-)

Your patch has been applied to the master and release/2.6 + 2.5 branch (bugfix, and trivial cherrypicking)

commit 4bf05d487cc10164615ad7c18931d063ca3eecc2 (master) commit bb27e40799dcfe51a8cd82b236ce404bd7ab93aa (release/2.6) commit 193b76ef6e95d86078a2636a38c04beb98c241b8 (release/2.5)

Author: Frank Lichtenheld
Date:   Thu Jan 22 13:57:07 2026 +0100
     manage: Do not trigger actions on management disconnect if not authenticated

     Signed-off-by: Frank Lichtenheld <[email protected]...>
     Acked-by: Arne Schwabe <[email protected]...>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1484
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg35390.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering

#5 lore raw
In reply to a message not in the archive

cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1484?usp=email )

The following approvals got outdated and were removed:
Code-Review+2 by plaisthos

Change subject: manage: Do not trigger actions on management disconnect if not authenticated
......................................................................

manage: Do not trigger actions on management disconnect if not authenticated

If the management interface requires authentication via password and the remote did not specify it, do not do trigger actions requested by --management-forget-disconnect and --management-signal on disconnect.

Github: openvpn-private-issues#5

Change-Id I575d65912ce9065a0b0868e73998b4a9aece62af

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1484
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg35390.html

---
M src/openvpn/manage.c

1 file changed, 3 insertions(+), 2 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/84/1484/2

src/openvpn/manage.c +3 -2
index 8fa8784..37ae6b3 100644
@@ -2073,13 +2073,14 @@
     }
     if (!exiting)
     {
-        if (man->settings.flags & MF_FORGET_DISCONNECT)
+        if (man->settings.flags & MF_FORGET_DISCONNECT && !man_password_needed(man))
         {
+            msg(D_MANAGEMENT, "MANAGEMENT: Reset authentication on disconnect");
             ssl_purge_auth(false);
             (void)ssl_clean_auth_token();
         }
 
-        if (man->settings.flags & MF_SIGNAL)
+        if (man->settings.flags & MF_SIGNAL && !man_password_needed(man))
         {
             int mysig = man_mod_signal(man, SIGUSR1);
             if (mysig >= 0)
Signature · 12 lines
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1484?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I575d65912ce9065a0b0868e73998b4a9aece62af
Gerrit-Change-Number: 1484
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
#6 lore raw
In reply to a message not in the archive

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1484?usp=email )

Change subject: manage: Do not trigger actions on management disconnect if not authenticated
......................................................................

manage: Do not trigger actions on management disconnect if not authenticated

If the management interface requires authentication via password and the remote did not specify it, do not do trigger actions requested by --management-forget-disconnect and --management-signal on disconnect.

Github: openvpn-private-issues#5

Change-Id I575d65912ce9065a0b0868e73998b4a9aece62af

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1484
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg35390.html

---
M src/openvpn/manage.c

1 file changed, 3 insertions(+), 2 deletions(-)
src/openvpn/manage.c +3 -2
index 8fa8784..37ae6b3 100644
@@ -2073,13 +2073,14 @@
     }
     if (!exiting)
     {
-        if (man->settings.flags & MF_FORGET_DISCONNECT)
+        if (man->settings.flags & MF_FORGET_DISCONNECT && !man_password_needed(man))
         {
+            msg(D_MANAGEMENT, "MANAGEMENT: Reset authentication on disconnect");
             ssl_purge_auth(false);
             (void)ssl_clean_auth_token();
         }
 
-        if (man->settings.flags & MF_SIGNAL)
+        if (man->settings.flags & MF_SIGNAL && !man_password_needed(man))
         {
             int mysig = man_mod_signal(man, SIGUSR1);
             if (mysig >= 0)

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1484?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I575d65912ce9065a0b0868e73998b4a9aece62af
Gerrit-Change-Number: 1484
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>